[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2255: IGNITE-19120 Raft client should get leader metadata along while getting leader itself

[via GitHub]

vldpyatkov commented on code in PR #2255:
URL: https://github.com/apache/ignite-3/pull/2255#discussion_r1244873078


##########
modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java:
##########
@@ -362,6 +448,22 @@ private String randomNode(Set<String> exceptNodes) {
         return list.get(0);
     }
 
+    /**
+     * Gets placement driver node name randomly.
+     *
+     * @param exceptNodes Nodes to skip.
+     * @return Node name.
+     */
+    private String randomPlacementDriverNode(Set<String> exceptNodes) {
+        ArrayList<String> list = new ArrayList<>(placementDriverNodeNames);
+
+        list.removeAll(exceptNodes);
+
+        Collections.shuffle(list);

Review Comment:
   Moreover, we are already using this way for the same reason in other place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org