korlov42 commented on code in PR #2196:
URL: https://github.com/apache/ignite-3/pull/2196#discussion_r1247560089
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java:
##########
@@ -533,6 +535,55 @@ public static NativeType columnType2NativeType(ColumnType
columnType, int precis
}
}
+ /** Checks whether cast operation is necessary in {@code SearchBound}. */
+ public static boolean needCastInSearchBounds(IgniteTypeFactory
typeFactory, RelDataType fromType, RelDataType toType) {
+ // Check custom data types first.
+ if (toType.getSqlTypeName() == SqlTypeName.ANY ||
fromType.getSqlTypeName() == SqlTypeName.ANY) {
+ return customDataTypeNeedCast(typeFactory, fromType, toType);
Review Comment:
why do even need call in needCastInSearchBounds? This is the very same rule
as in TypeCoercion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
