isapego commented on code in PR #2256:
URL: https://github.com/apache/ignite-3/pull/2256#discussion_r1247578481
##########
modules/platforms/cpp/ignite/tuple/binary_tuple_builder.cpp:
##########
@@ -66,44 +66,39 @@ binary_tuple_builder::binary_tuple_builder(tuple_num_t
element_count) noexcept
void binary_tuple_builder::start() noexcept {
element_index = 0;
- null_elements = 0;
value_area_size = 0;
entry_size = 0;
}
void binary_tuple_builder::layout() {
+ using namespace ignite::binary_tuple_common;
+
assert(element_index == element_count);
binary_tuple_common::header header;
- size_t nullmapSize = 0;
- if (null_elements) {
- header.set_nullmap_flag();
- nullmapSize = binary_tuple_common::get_nullmap_size(element_count);
- }
-
entry_size = header.set_entry_size(value_area_size);
std::size_t tableSize = entry_size * element_count;
Review Comment:
```suggestion
std::size_t table_size = entry_size * element_count;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
