AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254627643
##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -117,92 +117,35 @@ public static class Sql {
/** Session not found error. */
public static final int SESSION_NOT_FOUND_ERR =
SQL_ERR_GROUP.registerErrorCode(2);
- /** Invalid query error. */
- public static final int QUERY_INVALID_ERR =
SQL_ERR_GROUP.registerErrorCode(3);
-
/** Query without a result set error. */
public static final int QUERY_NO_RESULT_SET_ERR =
SQL_ERR_GROUP.registerErrorCode(4);
- /** Missing primary key error. */
- public static final int PRIMARY_KEY_MISSING_ERR =
SQL_ERR_GROUP.registerErrorCode(5);
-
- /** Multiple primary keys error. */
- public static final int PRIMARY_KEYS_MULTIPLE_ERR =
SQL_ERR_GROUP.registerErrorCode(6);
-
/** Schema not found. */
- public static final int SCHEMA_NOT_FOUND_ERR =
SQL_ERR_GROUP.registerErrorCode(7);
-
- /** Storage engine not valid. */
- public static final int STORAGE_ENGINE_NOT_VALID_ERR =
SQL_ERR_GROUP.registerErrorCode(8);
+ public static final int SCHEMA_NOT_FOUND_ERR =
SQL_ERR_GROUP.registerErrorCode(5);
/** Cursor is already closed error. */
- public static final int CURSOR_CLOSED_ERR =
SQL_ERR_GROUP.registerErrorCode(9);
-
- /** Constraint violation: some keys can't be inserted because they
violate unique constraint PK. */
- public static final int DUPLICATE_KEYS_ERR =
SQL_ERR_GROUP.registerErrorCode(10);
-
- /** Constraint violation: deleting a column that belongs to the index.
*/
- public static final int DROP_IDX_COLUMN_CONSTRAINT_ERR =
SQL_ERR_GROUP.registerErrorCode(11);
-
- /** Too many grouping expressions. */
- public static final int TOO_MANY_GROUPING_EXPRESSIONS_ERR =
SQL_ERR_GROUP.registerErrorCode(12);
-
- /** Unsupported sql operation. */
- public static final int UNSUPPORTED_SQL_OPERATION_KIND_ERR =
SQL_ERR_GROUP.registerErrorCode(13);
-
- /** Unsupported DDL operation. */
- public static final int UNSUPPORTED_DDL_OPERATION_ERR =
SQL_ERR_GROUP.registerErrorCode(14);
-
- /** Query validation error. */
- public static final int QUERY_VALIDATION_ERR =
SQL_ERR_GROUP.registerErrorCode(15);
+ public static final int CURSOR_CLOSED_ERR =
SQL_ERR_GROUP.registerErrorCode(6);
- /** Object is not found in schema. */
- public static final int OBJECT_NOT_FOUND_ERR =
SQL_ERR_GROUP.registerErrorCode(16);
+ /** Parsing error. */
+ public static final int PARSE_ERR = SQL_ERR_GROUP.registerErrorCode(7);
- /** Object already exists in schema. */
- public static final int OBJECT_ALREADY_EXISTS_ERR =
SQL_ERR_GROUP.registerErrorCode(17);
+ /** Validation error. */
+ public static final int VALIDATION_ERR =
SQL_ERR_GROUP.registerErrorCode(8);
- /** Query mapping error. */
- public static final int QUERY_MAPPING_ERR =
SQL_ERR_GROUP.registerErrorCode(19);
+ /** Constraint violation error. */
+ public static final int CONSTRAINT_VIOLATION_ERR =
SQL_ERR_GROUP.registerErrorCode(9);
- /** DDL execution error. */
- public static final int DDL_EXEC_ERR =
SQL_ERR_GROUP.registerErrorCode(20);
+ /** Internal SQL engine error. */
+ public static final int INTERNAL_EXECUTION_ERR =
SQL_ERR_GROUP.registerErrorCode(10);
- /** DML result error. */
- public static final int INVALID_DML_RESULT_ERR =
SQL_ERR_GROUP.registerErrorCode(21);
+ /** Runtime SQL engine error. */
+ public static final int RUNTIME_EXECUTION_ERR =
SQL_ERR_GROUP.registerErrorCode(11);
Review Comment:
I looked at a places where INTERNAL errors are thrown. It looks like
unrecoverable internal errors.
I mean that there is no way to fix the issue at runtime and possibly grid
should be stopped.
On the other hand, RUNTIME exception allow user to fix query string, create
missed entities or just retry because of new topology established, without grid
maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
