sashapolo commented on code in PR #2295:
URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1255915228
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRow.java:
##########
@@ -44,12 +47,11 @@ public interface BinaryRow {
/** Get has value flag: {@code true} if row has non-null value, {@code
false} otherwise. */
boolean hasValue();
+ int length();
+
/** Get ByteBuffer slice representing the binary tuple. */
ByteBuffer tupleSlice();
- /** Get byte array of the row. */
- byte[] bytes();
-
/** Returns the representation of this row as a Byte Buffer. */
ByteBuffer byteBuffer();
Review Comment:
Yes, it is used a lot in tests, this PR will be three times as big if I were
to remove it. It is also used to serialize rows as parts of Raft commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
