ibessonov commented on code in PR #2295:
URL: https://github.com/apache/ignite-3/pull/2295#discussion_r1257977808
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRow.java:
##########
@@ -44,12 +47,11 @@ public interface BinaryRow {
/** Get has value flag: {@code true} if row has non-null value, {@code
false} otherwise. */
boolean hasValue();
+ int length();
+
/** Get ByteBuffer slice representing the binary tuple. */
ByteBuffer tupleSlice();
- /** Get byte array of the row. */
- byte[] bytes();
-
/** Returns the representation of this row as a Byte Buffer. */
ByteBuffer byteBuffer();
Review Comment:
No, we should do it in a separate issue
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryRow.java:
##########
@@ -44,12 +47,11 @@ public interface BinaryRow {
/** Get has value flag: {@code true} if row has non-null value, {@code
false} otherwise. */
boolean hasValue();
+ int length();
+
/** Get ByteBuffer slice representing the binary tuple. */
ByteBuffer tupleSlice();
- /** Get byte array of the row. */
- byte[] bytes();
-
/** Returns the representation of this row as a Byte Buffer. */
ByteBuffer byteBuffer();
Review Comment:
> It is also used to serialize rows as parts of Raft commands.
This part we can remove. It would be better to convert these objects into a
BinaryRowMessage. Less memory manipulations, better performance. Ideally, there
should zero memory copying between layers. It's not achievable, but we should
try to be as close to is as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
