alievmirza commented on code in PR #2273:
URL: https://github.com/apache/ignite-3/pull/2273#discussion_r1258149634
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/disruptor/StripedDisruptor.java:
##########
@@ -214,7 +223,7 @@ void unsubscribe(NodeId nodeId) {
assert handler != null : format("Group of the event is unsupported
[nodeId={}, event={}]", event.nodeId(), event);
//TODO: IGNITE-15568 endOfBatch should be set to true to prevent
caching tasks until IGNITE-15568 has fixed.
- handler.onEvent(event, sequence, subscribers.size() > 1 ? true :
endOfBatch);
+ handler.onEvent(event, sequence, endOfBatch || subscribers.size()
>= 1 && !supportsBatches);
Review Comment:
How is this possible to `subscribers.size() >= 1` be false, taking into
account assertion above?
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageFactory.java:
##########
@@ -69,16 +70,24 @@ public class DefaultLogStorageFactory implements
LogStorageFactory {
/** Data column family handle. */
private ColumnFamilyHandle dataHandle;
+ /**
+ * Thread-local batch instance, used by {@link
RocksDbSharedLogStorage#appendEntriesToBatch(List)} and
+ * {@link RocksDbSharedLogStorage#commitWriteBatch()}.
+ * <br>
+ * Shared between instances to provide more efficient way of executing
batch updates.
+ */
+ @SuppressWarnings("ThreadLocalNotStaticFinal")
+ private final ThreadLocal<WriteBatch> threadLocalWriteBatch = new
ThreadLocal<>();
+
/**
* Constructor.
*
* @param path Path to the storage.
*/
- public DefaultLogStorageFactory(Path path) {
+ public DefaultLogStorageFactory(Path path, int stripes) {
Review Comment:
`stripes` param is not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
