nizhikov commented on code in PR #10778:
URL: https://github.com/apache/ignite/pull/10778#discussion_r1258496150


##########
modules/core/src/main/java/org/apache/ignite/configuration/DataStorageConfiguration.java:
##########
@@ -252,6 +253,14 @@ public class DataStorageConfiguration implements 
Serializable {
     @IgniteExperimental
     private long cdcWalDirMaxSize = DFLT_CDC_WAL_DIRECTORY_MAX_SIZE;
 
+    /** Maximum size of CDC buffer. */
+    @IgniteExperimental
+    private long maxCdcBufSize = (long)DFLT_WAL_SEGMENTS * 
DFLT_WAL_SEGMENT_SIZE;
+
+    /** CDC buffer consumer. */
+    @IgniteExperimental
+    private transient CdcBufferConsumer cdcConsumer;

Review Comment:
   Right now, CDC is enabled only for some data regions. 
   It will be more convinient to have `CdcBufferConsumer` near the `cdcEnabled` 
flag.
   
   Right now, it's not clear what is enabled if 
`DataStorageConfiguration#cdcConsumer` set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to