isapego commented on code in PR #2322:
URL: https://github.com/apache/ignite-3/pull/2322#discussion_r1265217130
##########
modules/platforms/cpp/ignite/odbc/query/data_query.h:
##########
@@ -129,7 +129,27 @@ class data_query : public query
*
* @return true, if all cursors closed remotely.
*/
- [[nodiscard]] bool is_closed_remotely() const;
+ [[nodiscard]] bool is_closed_remotely() const {
+ return !m_has_more_pages;
Review Comment:
Agree. This is ported code so yeah, may look a bit weird. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
