sashapolo commented on code in PR #2355:
URL: https://github.com/apache/ignite-3/pull/2355#discussion_r1274569020
##########
modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/BaseIgniteAbstractTest.java:
##########
@@ -90,6 +92,12 @@ protected void tearDownBase(TestInfo testInfo) {
testInfo.getDisplayName(), monotonicMs() - testStartMs);
}
+ @AfterAll
+ static void afterAll() {
Review Comment:
Please rename this method to something more meaningful, otherwise it's name
may clash with names in subclasses
##########
modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/BaseIgniteAbstractTest.java:
##########
@@ -90,6 +92,12 @@ protected void tearDownBase(TestInfo testInfo) {
testInfo.getDisplayName(), monotonicMs() - testStartMs);
}
+ @AfterAll
+ static void afterAll() {
Review Comment:
Please rename this method to something more meaningful, otherwise its name
may clash with names in subclasses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
