denis-chudov commented on code in PR #2095:
URL: https://github.com/apache/ignite-3/pull/2095#discussion_r1274956426
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/BaseDistributionZoneManagerTest.java:
##########
@@ -124,6 +124,7 @@ void setUp() {
zonesConfiguration =
registry.getConfiguration(DistributionZonesConfiguration.KEY);
distributionZoneManager = new DistributionZoneManager(
+ null,
Review Comment:
It seems weird to me that we have `DistributionZoneCausalityDataNodesTest`,
and `DistributionZoneManager#waitZoneProcessing` is never tested - neither
there, nor in other places. And this injection of `null` assumes that this
method will not work in derived classes. Is it correct that there are no tests
for `DistributionZoneManager#waitZoneProcessing`? And, at least, maybe we
should care about possible extensions of derived tests and inject the correct
value here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
