[GitHub] [ignite-3] lowka commented on a diff in pull request #2342: IGNITE-18453: Query executor thread synchronously waits for leaders on query mapping.

[via GitHub]

lowka commented on code in PR #2342:
URL: https://github.com/apache/ignite-3/pull/2342#discussion_r1275198490


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -820,6 +830,27 @@ private void enlist(SourceAwareIgniteRel rel) {
             }.visit(fragment.root());
         }
 
+        private CompletableFuture<MultiStepPlan> mapFragments(MultiStepPlan 
plan) {
+            List<IgniteRel> fragments = plan.fragments()
+                    .stream()
+                    .map(Fragment::root)
+                    .collect(Collectors.toList());

Review Comment:
   Well, here is a problem it is a bad idea to accept an iterator because is 
modifiable. We need something like transforming iterable here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org