ascherbakoff commented on code in PR #2321:
URL: https://github.com/apache/ignite-3/pull/2321#discussion_r1275851554


##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/snapshot/local/LocalSnapshotStorage.java:
##########
@@ -223,7 +223,7 @@ void close(final LocalSnapshotWriter writer, final boolean 
keepDataOnError) thro
                 break;
             }
             LOG.info("Renaming {} to {}.", tempPath, newPath);
-            if (!new File(tempPath).renameTo(new File(newPath))) {
+            if (!Utils.atomicMoveFile(new File(tempPath), new File(newPath), 
true)) {

Review Comment:
   Should we fix it in LocalSnapshotStorage as well ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to