AMashenkov commented on code in PR #2312:
URL: https://github.com/apache/ignite-3/pull/2312#discussion_r1276103807
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/MapReduceHashAggregatePlannerTest.java:
##########
@@ -318,11 +324,9 @@ public void expandDistinctAggregates() throws Exception {
.and(input(isInstanceOf(IgniteReduceHashAggregate.class)
.and(not(hasAggregate()))
.and(hasGroups())
- .and(input(isInstanceOf(IgniteExchange.class)
-
.and(input(isInstanceOf(IgniteMapHashAggregate.class)
- .and(not(hasAggregate()))
- .and(hasGroups())
- ))
+
.and(input(isInstanceOf(IgniteMapHashAggregate.class)
+ .and(not(hasAggregate()))
+ .and(hasGroups())
Review Comment:
Seems, `IgniteMdDistinctRowCount.getDistinctRowCount` is used for
calculating aggregate nodes costs.
It's code looks weird. BTW, I have no idea why don't we use default
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
