rpuch commented on code in PR #2375:
URL: https://github.com/apache/ignite-3/pull/2375#discussion_r1277565850
##########
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryServerHandshakeManager.java:
##########
@@ -177,12 +182,20 @@ public void onMessage(NetworkMessage message) {
if (message instanceof HandshakeRejectedMessage) {
HandshakeRejectedMessage msg = (HandshakeRejectedMessage) message;
- LOG.warn("Handshake rejected by client: {}", msg.reason());
+ boolean ignorable = stopping.get() || !msg.critical();
Review Comment:
If a node are stopping, then the situation 'I was not let by another node to
do a handshake' is expected and should neither cause anything (serious) be
logged nor fail the node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
