nevdmitry commented on code in PR #2359:
URL: https://github.com/apache/ignite-3/pull/2359#discussion_r1278820315
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/call/connect/ConnectCall.java:
##########
@@ -81,8 +86,8 @@ public CallOutput<String> execute(UrlCallInput input) {
stateConfigProvider.get().setProperty(CliConfigKeys.LAST_CONNECTED_URL.value(),
nodeUrl);
String jdbcUrl = jdbcUrlFactory.constructJdbcUrl(configuration,
nodeUrl);
- session.connect(new SessionInfo(nodeUrl, fetchNodeName(nodeUrl),
jdbcUrl, username));
-
+ session.connect(new SessionInfo(nodeUrl, fetchNodeName(nodeUrl),
jdbcUrl, username, ConnectionStatus.OPEN));
+ connectionHeartBeat.start(session, clientFactory);
Review Comment:
it is good idea but due to some circular dependencies between Session and
ReplPromtProvider I leave it as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
