AMashenkov commented on code in PR #2254: URL: https://github.com/apache/ignite-3/pull/2254#discussion_r1279168846
########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/StopCalciteModuleTest.java: ########## Review Comment: I'd drop this test class, as we don't check real behaviour of SqlQueryProcessor. There are bunch of mocks, without making clear how they affect the SqlQueryProcessor. If we want to check all nodes stop their threads in various scenarious, then it would be more affective making this check at tearDown stage for every integration test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
