tkalkirill commented on code in PR #2254:
URL: https://github.com/apache/ignite-3/pull/2254#discussion_r1280135777
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItCommonApiTest.java:
##########
@@ -123,37 +115,25 @@ public void testSessionExpiration() throws Exception {
@Test
public void checkTimestampOperations() {
String kvTblName = "tbl_all_columns_sql";
- String schemaName = "PUBLIC";
- String keyCol = "key";
- int maxTimePrecision = TemporalColumnType.MAX_TIME_PRECISION;
+ String keyCol = "KEY";
Ignite node = CLUSTER_NODES.get(0);
// TODO: https://issues.apache.org/jira/browse/IGNITE-19162 Trim all
less than millisecond information from timestamp
//String tsStr = "2023-03-29T08:22:33.005007Z";
- String tsStr = "2023-03-29T08:22:33.005Z";
+ String tsStr = "2023-03-29T08:22:33Z";
Instant ins = Instant.parse(tsStr);
sql("CREATE TABLE timestamps(id INTEGER PRIMARY KEY, i TIMESTAMP(9))");
- TableDefinition schTblAllSql = SchemaBuilders.tableBuilder(schemaName,
kvTblName).columns(
- SchemaBuilders.column(keyCol, ColumnType.INT64).build(),
- SchemaBuilders.column("time",
ColumnType.time(maxTimePrecision)).asNullable(true).build(),
- SchemaBuilders.column("timestamp",
ColumnType.timestamp(maxTimePrecision)).asNullable(true).build(),
- SchemaBuilders.column("datetime",
ColumnType.datetime(maxTimePrecision)).asNullable(true).build()
- ).withPrimaryKey(keyCol).build();
-
- await(((TableManager)
node.tables()).createTableAsync(schTblAllSql.name(), DEFAULT_ZONE_NAME, tblCh ->
- SchemaConfigurationConverter.convert(schTblAllSql, tblCh)
- ));
+ sql(String.format("CREATE TABLE %s(\"%s\" INTEGER PRIMARY KEY,
\"TIMESTAMP\" TIMESTAMP(9))", kvTblName, keyCol));
Review Comment:
There is a nuance here, here I left
`org.apache.ignite.sql.ColumnType#DATETIME` which in SQL has the
`org.apache.calcite.sql.type.SqlTypeName#TIMESTAMP`, but I can’t use
`org.apache.ignite.sql.ColumnType#TIMESTAMP` because in SQL it is type
`org.apache.calcite.sql.type.SqlTypeName#TIMESTAMP_WITH_LOCAL_TIME_ZONE` which
does not currently work here is the IGNITE-17376 and IGNITE-19274.
I looked at the mapping in
`org.apache.ignite.internal.sql.engine.util.TypeUtils#columnType`.
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItCommonApiTest.java:
##########
@@ -123,37 +115,25 @@ public void testSessionExpiration() throws Exception {
@Test
public void checkTimestampOperations() {
String kvTblName = "tbl_all_columns_sql";
- String schemaName = "PUBLIC";
- String keyCol = "key";
- int maxTimePrecision = TemporalColumnType.MAX_TIME_PRECISION;
+ String keyCol = "KEY";
Ignite node = CLUSTER_NODES.get(0);
// TODO: https://issues.apache.org/jira/browse/IGNITE-19162 Trim all
less than millisecond information from timestamp
//String tsStr = "2023-03-29T08:22:33.005007Z";
- String tsStr = "2023-03-29T08:22:33.005Z";
+ String tsStr = "2023-03-29T08:22:33Z";
Instant ins = Instant.parse(tsStr);
sql("CREATE TABLE timestamps(id INTEGER PRIMARY KEY, i TIMESTAMP(9))");
- TableDefinition schTblAllSql = SchemaBuilders.tableBuilder(schemaName,
kvTblName).columns(
- SchemaBuilders.column(keyCol, ColumnType.INT64).build(),
- SchemaBuilders.column("time",
ColumnType.time(maxTimePrecision)).asNullable(true).build(),
- SchemaBuilders.column("timestamp",
ColumnType.timestamp(maxTimePrecision)).asNullable(true).build(),
- SchemaBuilders.column("datetime",
ColumnType.datetime(maxTimePrecision)).asNullable(true).build()
- ).withPrimaryKey(keyCol).build();
-
- await(((TableManager)
node.tables()).createTableAsync(schTblAllSql.name(), DEFAULT_ZONE_NAME, tblCh ->
- SchemaConfigurationConverter.convert(schTblAllSql, tblCh)
- ));
+ sql(String.format("CREATE TABLE %s(\"%s\" INTEGER PRIMARY KEY,
\"TIMESTAMP\" TIMESTAMP(9))", kvTblName, keyCol));
Review Comment:
There is a nuance here, here I left
`org.apache.ignite.sql.ColumnType#DATETIME` which in SQL has the
`org.apache.calcite.sql.type.SqlTypeName#TIMESTAMP`, but I can’t use
`org.apache.ignite.sql.ColumnType#TIMESTAMP` because in SQL it is type
`org.apache.calcite.sql.type.SqlTypeName#TIMESTAMP_WITH_LOCAL_TIME_ZONE` which
does not currently work here is the IGNITE-17376 and IGNITE-19274.
I looked at the mapping in
`org.apache.ignite.internal.sql.engine.util.TypeUtils#columnType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
