timoninmaxim commented on code in PR #10864:
URL: https://github.com/apache/ignite/pull/10864#discussion_r1280558405
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/TxDeadlockDetection.java:
##########
@@ -285,7 +284,7 @@ private void map(@Nullable Set<IgniteTxKey> keys,
Map<IgniteTxKey, TxLockList> t
assert set;
- if (nodeId == null || itersCnt++ >= DEADLOCK_MAX_ITERS || timedOut)
+ if (nodeId == null || itersCnt++ >= cctx.tm().deadlockMaxIters ||
timedOut)
Review Comment:
Let's invoke method instead accessing variable
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java:
##########
@@ -1762,7 +1698,7 @@ else if (log.isDebugEnabled())
*/
public void fastFinishTx(GridNearTxLocal tx, boolean commit, boolean
clearThreadMap) {
assert tx != null;
- tx.writeMap().isEmpty();
Review Comment:
Let's add `assert` for this condition, instead of removing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
