AMashenkov commented on code in PR #2391:
URL: https://github.com/apache/ignite-3/pull/2391#discussion_r1285574222
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java:
##########
@@ -155,9 +204,10 @@ public static CatalogZoneDescriptor fromParams(int id,
CreateZoneParams params)
* @return Column descriptor.
*/
public static CatalogTableColumnDescriptor fromParams(ColumnParams params)
{
- int precision = params.precision() != null ? params.precision() : 0;
- int scale = params.scale() != null ? params.scale() : 0;
- int length = params.length() != null ? params.length() : 0;
+ int precision = params.precision() != null ? params.precision() :
defaultPrecision(params.type());
Review Comment:
1. java.util.Objects#requireNonNullElse will force argument evaluation.
2. `int` argument will be boxed/unboxed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
