[GitHub] [ignite-3] Cyrill commented on a diff in pull request #2386: IGNITE-19294 Support merged configuration roots for multiple modules

[via GitHub]

Cyrill commented on code in PR #2386:
URL: https://github.com/apache/ignite-3/pull/2386#discussion_r1288107801


##########
modules/configuration/src/test/java/org/apache/ignite/internal/configuration/util/ConfigurationUtilTest.java:
##########
@@ -548,42 +549,64 @@ void testCheckConfigurationTypeNoError() {
     }
 
     @Test
-    void testInternalSchemaExtensions() {
-        assertTrue(internalSchemaExtensions(List.of()).isEmpty());
+    void testExtensionsType() {
+        // public extensions
+        
assertTrue(ConfigurationUtil.isPublicExtension(PublicConfigurationSchema.class));

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org