Flaugh24 commented on code in PR #2390: URL: https://github.com/apache/ignite-3/pull/2390#discussion_r1288346028
########## modules/file-transfer/src/main/java/org/apache/ignite/internal/network/file/FileSender.java: ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.file; + +import java.io.File; +import java.io.IOException; +import java.util.List; +import java.util.UUID; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.LinkedBlockingQueue; +import java.util.concurrent.ThreadPoolExecutor; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicReference; +import java.util.function.BiFunction; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.thread.NamedThreadFactory; +import org.apache.ignite.internal.util.IgniteUtils; +import org.apache.ignite.network.NetworkMessage; + +class FileSender { + private static final IgniteLogger LOG = Loggers.forClass(FileSender.class); + + private final int chunkSize; + + private final RateLimiter rateLimiter; + + private final BiFunction<String, NetworkMessage, CompletableFuture<Void>> send; + + private final ExecutorService executorService; + + FileSender( + String nodeName, + int chunkSize, + int threadPoolSize, + RateLimiter rateLimiter, + BiFunction<String, NetworkMessage, CompletableFuture<Void>> send) { + this.send = send; + this.chunkSize = chunkSize; + this.rateLimiter = rateLimiter; + this.executorService = new ThreadPoolExecutor( + 0, + threadPoolSize, + 0L, TimeUnit.MILLISECONDS, + new LinkedBlockingQueue<Runnable>(), + NamedThreadFactory.create(nodeName, "file-sender", LOG) + ); + } + + /** + * Adds files to the queue to be sent to the receiver. + */ + CompletableFuture<Void> send(String receiverConsistentId, UUID id, List<File> files) { + return CompletableFuture.runAsync(() -> send0(receiverConsistentId, id, files), executorService); + } + + private void send0(String receiverConsistentId, UUID id, List<File> files) { + AtomicReference<Throwable> error = new AtomicReference<>(); + try (FileTransferMessagesStream stream = new FileTransferMessagesStream(id, files, chunkSize)) { + while (stream.hasNextMessage() && error.get() == null && !Thread.currentThread().isInterrupted()) { + if (rateLimiter.tryAcquire()) { + CompletableFuture.completedFuture(stream.nextMessage()) + .thenCompose(message -> send.apply(receiverConsistentId, message)) + .whenComplete((res, e) -> { + try { + if (e != null) { + LOG.error("Failed to send message to node: {}, transfer id: {}. Exception: {}", + receiverConsistentId, + id, + e + ); + error.compareAndSet(null, e); + } + } finally { + rateLimiter.release(); + } + }); + } + } + + if (error.get() != null) { Review Comment: Because it doesn't make sense to continue file transfer if there is a failure in one of the files. Currently, the service doesn't provide recovery functionality. If an error happens during a transfer, the transfer must be started from scratch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
