xtern commented on code in PR #2449:
URL: https://github.com/apache/ignite-3/pull/2449#discussion_r1295973628
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/jdbc/JdbcQueryCursor.java:
##########
@@ -86,4 +88,10 @@ public SqlQueryType queryType() {
public ResultSetMetadata metadata() {
return cur.metadata();
}
+
+ /** {@inheritDoc} */
+ @Override
+ public @Nullable HybridTimestamp observableTimestamp() {
+ return cur.observableTimestamp();
Review Comment:
I see two options:
- remove inheritance from SqlAsyncCursor in JdbcQueryCursor
- add something like BaseSqlAsyncCursor interface with public methods.
What do you think?
p.s. I updated PR with option 1 (removed inheritance).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
