tkalkirill commented on code in PR #2456:
URL: https://github.com/apache/ignite-3/pull/2456#discussion_r1296744690


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -402,7 +402,8 @@ public CompletableFuture<Integer> 
createZone(DistributionZoneConfigurationParame
                         }
 
                         if (distributionZoneCfg.dataStorageChangeConsumer() == 
null) {
-                            zoneChange.changeDataStorage(ch -> 
ch.convert(zonesConfiguration.defaultDataStorage().value()));
+                            // TODO: IGNITE-20114 Delete when switching to the 
catalog
+                            zoneChange.changeDataStorage(ch -> 
ch.convert("aipersist"));

Review Comment:
   That code in the neighboring 
[PR](https://github.com/apache/ignite-3/pull/2415) disappears, I don’t think 
that a constant is needed here.



##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -402,7 +402,8 @@ public CompletableFuture<Integer> 
createZone(DistributionZoneConfigurationParame
                         }
 
                         if (distributionZoneCfg.dataStorageChangeConsumer() == 
null) {
-                            zoneChange.changeDataStorage(ch -> 
ch.convert(zonesConfiguration.defaultDataStorage().value()));
+                            // TODO: IGNITE-20114 Delete when switching to the 
catalog
+                            zoneChange.changeDataStorage(ch -> 
ch.convert("aipersist"));

Review Comment:
   That code in the neighboring 
[PR](https://github.com/apache/ignite-3/pull/2415) disappears, I don’t think 
that a constant is needed here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to