rpuch commented on code in PR #2450:
URL: https://github.com/apache/ignite-3/pull/2450#discussion_r1301112670
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/action/RequestType.java:
##########
@@ -79,6 +79,13 @@ public boolean isSingleRow() {
}
}
+ /**
+ * Returns {@code true} if the operation works with a single row and it's
a write.
+ */
+ public boolean isSingleRowWrite() {
Review Comment:
I mean, `RequestType` is an enum, it had no code before these methods were
added. And the methods are about the members of the enum, so it is not
unnatural for them to belong to the enum. The only thing is that these methods
are only used in tests, but it does not look like a crime.
I would certainly not want to move them to `PartitionReplicaListenerTest`
which is already pretty big.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
