zstan commented on code in PR #2468:
URL: https://github.com/apache/ignite-3/pull/2468#discussion_r1302511616
##########
check-rules/pmd-rules.xml:
##########
@@ -43,4 +43,23 @@
-->
<!-- <rule ref="category/java/bestpractices.xml/UnusedPrivateMethod"
/>-->
+ <rule name="Prohibited classes"
+ language="java"
+ message="Avoid using these classes."
+ class="net.sourceforge.pmd.lang.rule.XPathRule" >
+ <description>
+ Avoid using these classes.
+ </description>
+ <priority>3</priority>
+ <properties>
+ <property name="xpath">
+ <value>
+ <![CDATA[
+//Name[pmd-java:typeIs('org.jetbrains.annotations.NotNull')]
Review Comment:
however i observe passed check on tests :
@NotNull
private List<String> prepareNetworkTopology(int nodes) {
./gradlew pmdMain checkstyleMain checkstyleTest
checkstyleIntegrationTest checkstyleTestFixtures modernizer
did i miss smth ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
