korlov42 commented on code in PR #2460:
URL: https://github.com/apache/ignite-3/pull/2460#discussion_r1302864119
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -315,8 +315,6 @@ public void testDecimalLiteral() {
assertQuery("SELECT CASE WHEN false THEN DECIMAL '1.00' ELSE DECIMAL
'0.0' END")
.returns(new BigDecimal("0.0")).check();
- assertQuery("SELECT DECIMAL \"10\" FROM (SELECT 1 as decimal)
tmp").returns(1).check();
Review Comment:
this particular case verifies that `DECIMAL \"10\"` is parsed as column name
and alias and not like decimal literal. In this patch keyword `DECIMAL` becomes
reserved, rendering such construction not possible anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
