AMashenkov commented on code in PR #2485:
URL: https://github.com/apache/ignite-3/pull/2485#discussion_r1302902536
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommandParams.java:
##########
@@ -17,57 +17,32 @@
package org.apache.ignite.internal.catalog.commands;
-/**
- * Abstract index ddl command.
- */
+import org.jetbrains.annotations.Nullable;
+
+/** Abstract create index ddl command. */
public abstract class AbstractIndexCommandParams implements DdlCommandParams {
/** Index name. */
protected String indexName;
- /** Schema name where this new index will be created. */
- protected String schema;
-
- /** Table name. */
- protected String tableName;
-
- /** Unique index flag. */
- protected boolean unique;
+ /** Schema name. */
+ protected @Nullable String schemaName;
- /**
- * Returns index simple name.
- */
+ /** Returns index name. */
public String indexName() {
return indexName;
}
- /**
- * Returns schema name.
- */
- public String schemaName() {
- return schema;
+ /** Returns schema name. */
+ public @Nullable String schemaName() {
Review Comment:
@rpuch, yes, user may try create index/table in "default" schema (usually
`PUBLIC`,but can be overridden for a query/session/cluster).
So, `null` here is a special value that means we should use some default
schema instead.
It make sense to mark builder setter param as nullable, and mention in
javadoc that `null` == "default"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
