[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2476: IGNITE-19788 Sql. Change QueryBatchMessage serialization

[via GitHub]

korlov42 commented on code in PR #2476:
URL: https://github.com/apache/ignite-3/pull/2476#discussion_r1303004069


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/RowHandler.java:
##########
@@ -48,5 +51,7 @@ interface RowFactory<RowT> {
         RowT create();
 
         RowT create(Object... fields);
+
+        RowT create(ByteBuffer raw);

Review Comment:
   I believe it's time to improve javadoc for this class. Please address at 
least newly introduced methods. It would be nice to cover few more methods



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org