tkalkirill commented on code in PR #2493:
URL: https://github.com/apache/ignite-3/pull/2493#discussion_r1305330468
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CreateTableParams.java:
##########
@@ -20,67 +20,51 @@
import java.util.List;
import org.jetbrains.annotations.Nullable;
-/**
- * CREATE TABLE statement.
- */
+/** CREATE TABLE statement. */
public class CreateTableParams extends AbstractTableCommandParams {
/** Creates parameters builder. */
public static Builder builder() {
return new Builder();
}
+ private CreateTableParams() {
+ // No-op.
+ }
+
/** Primary key columns. */
- @Nullable
private List<String> pkCols;
/** Colocation columns. */
- @Nullable
private List<String> colocationCols;
- /** Columns. */
- private List<ColumnParams> cols;
+ /** Columns, {@code null} if not set. */
+ private @Nullable List<ColumnParams> cols;
Review Comment:
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]