rpuch commented on code in PR #2506:
URL: https://github.com/apache/ignite-3/pull/2506#discussion_r1308554480
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -1664,4 +1664,17 @@ public void
unregisterRevisionUpdateListener(RevisionUpdateListener listener) {
public CompletableFuture<Void> notifyRevisionUpdateListenerOnStart(long
newRevision) {
return watchProcessor.notifyUpdateRevisionListeners(newRevision);
}
+
+ @Override
+ public void advanceSafeTime(HybridTimestamp newSafeTime) {
+ rwLock.writeLock().lock();
Review Comment:
`WatchProcessor.advanceSafeTime()` chains `notificationFuture` with its
previous version, this must be done under a lock.
`WatchProcessor.notifyWatches()` does the same, and its correctness is backed
by taking the write lock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
