kgusakov commented on code in PR #2517:
URL: https://github.com/apache/ignite-3/pull/2517#discussion_r1319090419
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -560,6 +578,19 @@ public CompletableFuture<Boolean>
notify(SchemaEventParameters parameters, @Null
addMessageHandler(clusterService.messagingService());
}
+ private CompletableFuture<Void> performRebalanceOnRecovery(long revision) {
+ var startRange = new ByteArray(PENDING_ASSIGNMENTS_PREFIX);
+ var endRange = new
ByteArray(incrementLastChar(PENDING_ASSIGNMENTS_PREFIX));
Review Comment:
Maybe I didn't understand something, but we can receive
`IllegalArgumentException` here, if last char is the `Character.MAX_VALUE`. But
I think instead we want to have a `new
ByteArray(PENDING_ASSIGNMENTS_PREFIX).getBytes(StandardCharsets.UTF_8) ++
[Character.MIN_VALUE])`to achieve the our goal (where ++ is a pseudocode for
arrays concatenation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
