korlov42 opened a new pull request, #2568: URL: https://github.com/apache/ignite-3/pull/2568
This patch is split onto 2 commits. First commit introduces a benchmark only, so everyone may measure performance of the current behaviour. Second commit introduces the changes that aim to improve performance. I run this benchmark on my laptop (MBP 2019, 2,6 GHz 6-Core Intel Core i7, 32 GB ) and here are the numbers: | Benchmark | fsync | Mode | Cnt | Before | After | | --- | --- | --- | --- | --- | --- | | SqlOneNodeBenchmark.count1 | false | avgt | 5 | 223.324 ± 4.092 ms/op | 40.887 ± 1.624 ms/op | | SqlOneNodeBenchmark.countAll | false | avgt | 5 | 228.180 ± 9.737 ms/op | 39.384 ± 1.484 ms/op | | SqlOneNodeBenchmark.countKey | false | avgt | 5 | 222.424 ± 7.148 ms/op | 41.607 ± 2.867 ms/op | | SqlOneNodeBenchmark.countVal | false | avgt | 5 | 83.615 ± 5.109 ms/op | 43.754 ± 1.495 ms/op | | SqlOneNodeBenchmark.selectAll | false | avgt | 5 | 228.978 ± 5.071 ms/op | 209.693 ± 7.208 ms/op | -------------------------------------------- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ### The Review Checklist - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following: \- There is a single JIRA ticket related to the pull request. \- The web-link to the pull request is attached to the JIRA ticket. \- The JIRA ticket has the Patch Available state. \- The description of the JIRA ticket explains WHAT was made, WHY and HOW. \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue. - [ ] **Design:** new code conforms with the design principles of the components it is added to. - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable. - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed. - [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources. ### Notes - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
