xtern commented on code in PR #2563:
URL: https://github.com/apache/ignite-3/pull/2563#discussion_r1321913576
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogTableDescriptor.java:
##########
@@ -96,6 +101,10 @@ public int zoneId() {
return zoneId;
}
+ public int primaryKeyId() {
+ return primaryKeyId;
Review Comment:
* Personally I prefer `pkIndexId` for the variable name and
`primaryKeyIndexId()` for this method
* It looks strange that we have pkColumns and pkIndexId at the same time, as
far as I understand, we can always check that it is a PK index if it consists
of the 'pkColumns', right? ...Or vice-versa, we should be able to get a list of
pk columns by pkIndexId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
