[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2488: IGNITE-18856 Switch primary replica calls from Raft leader to primary replica

[via GitHub]

vldpyatkov commented on code in PR #2488:
URL: https://github.com/apache/ignite-3/pull/2488#discussion_r1322862259


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2806,4 +2839,16 @@ private void markFinished(UUID txId, TxState txState, 
@Nullable HybridTimestamp
                 ? null
                 : new TxStateMeta(txState, old.txCoordinatorId(), txState == 
COMMITED ? commitTimestamp : null));
     }
+
+    // TODO: https://issues.apache.org/jira/browse/IGNITE-20124 tmp
+    private static <T extends Comparable<T>> void 
updateTrackerIgnoringTrackerClosedException(

Review Comment:
   Why we do not update safte time on the primary replica (only ins RAFT state 
machine), but we do it in your patch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org