rpuch commented on code in PR #2566:
URL: https://github.com/apache/ignite-3/pull/2566#discussion_r1322941251
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1665,12 +1695,12 @@ private CompletableFuture<Object>
processMultiEntryAction(ReadWriteMultiRowRepli
}
if (rowIdsToDelete.isEmpty()) {
- return completedFuture(result);
+ return completedFuture(didNoWrites(result));
}
- return updateAllCommand(request, rowIdsToDelete,
txCoordinatorId)
+ return chooseOpTsValidateAndBuildUpdateAllCommand(request,
rowIdsToDelete, txCoordinatorId)
Review Comment:
It seems that we must choose the timestamp after we take locks (otherwise an
operation that already took a timestamp [and hence must be executed before
operations that take ts after it] and cannot take a lock for a long time would
block all other RW operations on the same partition), so we cannot do it before
this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
