tkalkirill commented on code in PR #2581:
URL: https://github.com/apache/ignite-3/pull/2581#discussion_r1324119833
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2202,7 +2220,11 @@ public CompletableFuture<Void> onUpdate(WatchEvent evt) {
try {
assert evt.single();
- return
handleChangePendingAssignmentEvent(evt.entryEvent().newEntry());
+ return recoveryFuture.thenComposeAsync(v -> {
Review Comment:
Yes, at the same time it allows you to avoid races when updating the
metastore revision, which can ruin someone’s life)
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2202,7 +2220,11 @@ public CompletableFuture<Void> onUpdate(WatchEvent evt) {
try {
assert evt.single();
- return
handleChangePendingAssignmentEvent(evt.entryEvent().newEntry());
+ return recoveryFuture.thenComposeAsync(v -> {
Review Comment:
Yes, at the same time it allows you to avoid races when updating the
metastore revision, which can ruin someone’s life)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
