sashapolo commented on code in PR #2590:
URL: https://github.com/apache/ignite-3/pull/2590#discussion_r1326014239
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -215,22 +217,21 @@ private CompletableFuture<Boolean>
onIndexCreate(CreateIndexEventParameters para
private CompletableFuture<Void> createIndexLocally(
long causalityToken,
+ int catalogVersion,
CatalogTableDescriptor table,
CatalogIndexDescriptor index
) {
int tableId = table.id();
int indexId = index.id();
- if (LOG.isInfoEnabled()) {
Review Comment:
Why did you remove this check?
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/index/ItIndexManagerTest.java:
##########
@@ -53,6 +53,8 @@ public void eventsAreFiredWhenIndexesCreatedAndDropped() {
String tableName = "TNAME";
+ int catalogVersion = ((IgniteImpl)
ignite).catalogManager().latestCatalogVersion();
Review Comment:
Maybe we should do the `(IgniteImpl)` cast to the first line of this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
