tkalkirill commented on code in PR #2592:
URL: https://github.com/apache/ignite-3/pull/2592#discussion_r1327074196
##########
modules/core/src/test/java/org/apache/ignite/internal/event/EventProducerTest.java:
##########
@@ -45,26 +42,23 @@ public void simpleAsyncTest() {
CompletableFuture<?> eventHandleFuture =
producer.fireEvent(TestEvent.TEST, new TestEventParameters(0L));
- assertFalse(eventHandleFuture.isDone());
+ assertThat(eventHandleFuture, willTimeoutFast());
future.complete(true);
- assertTrue(eventHandleFuture.isDone());
+ assertThat(eventHandleFuture, willCompleteSuccessfully());
Review Comment:
This way we will check that the future completed successfully without errors
instead of two checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
