nizhikov commented on code in PR #10936: URL: https://github.com/apache/ignite/pull/10936#discussion_r1328617815
########## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/AbstractCreateSnapshotFutureTask.java: ########## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache.persistence.snapshot; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutionException; +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.binary.BinaryType; +import org.apache.ignite.internal.IgniteFutureCancelledCheckedException; +import org.apache.ignite.internal.processors.cache.CacheGroupContext; +import org.apache.ignite.internal.processors.cache.GridCacheSharedContext; +import org.apache.ignite.internal.processors.cache.distributed.dht.topology.GridDhtLocalPartition; +import org.apache.ignite.internal.processors.cache.distributed.dht.topology.GridDhtPartitionState; +import org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointListener; +import org.apache.ignite.internal.processors.marshaller.MappedName; +import org.apache.ignite.internal.util.lang.IgniteThrowableRunner; +import org.apache.ignite.internal.util.typedef.F; +import org.apache.ignite.internal.util.typedef.internal.S; +import org.apache.ignite.internal.util.typedef.internal.U; + +import static org.apache.ignite.internal.pagemem.PageIdAllocator.INDEX_PARTITION; + +/** + * + */ +public abstract class AbstractCreateSnapshotFutureTask extends AbstractSnapshotFutureTask<SnapshotFutureTaskResult> { + /** + * Cache group and corresponding partitions collected under the PME lock. + * For full snapshot additional checkpoint write lock required. + * @see SnapshotFutureTask#onMarkCheckpointBegin(CheckpointListener.Context) + */ + protected final Map<Integer, Set<Integer>> processed = new HashMap<>(); + + /** Future which will be completed when task requested to be closed. Will be executed on system pool. */ + protected volatile CompletableFuture<Void> closeFut; + + /** + * @param cctx Shared context. + * @param srcNodeId Node id which cause snapshot task creation. + * @param reqId Snapshot operation request ID. + * @param snpName Snapshot name. + * @param snpSndr Factory which produces snapshot sender instance. + * @param parts Partitions to be processed. + */ + protected AbstractCreateSnapshotFutureTask( + GridCacheSharedContext<?, ?> cctx, + UUID srcNodeId, + UUID reqId, + String snpName, + SnapshotSender snpSndr, + Map<Integer, Set<Integer>> parts + ) { + super(cctx, srcNodeId, reqId, snpName, snpSndr, parts); + } + + /** */ + protected abstract List<CompletableFuture<Void>> saveCacheConfigsCopy(); Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
