Vladsz83 commented on code in PR #10933:
URL: https://github.com/apache/ignite/pull/10933#discussion_r1331510236
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/QueryTaskExecutorImpl.java:
##########
@@ -82,16 +85,18 @@ public void
exceptionHandler(Thread.UncaughtExceptionHandler eHnd) {
@Override public void onStart(GridKernalContext ctx) {
exceptionHandler(ctx.uncaughtExceptionHandler());
- CalciteQueryProcessor proc =
Objects.requireNonNull(Commons.lookupComponent(ctx,
CalciteQueryProcessor.class));
-
- stripedThreadPoolExecutor(new IgniteStripedThreadPoolExecutor(
+ IgniteStripedThreadPoolExecutor executor = new
IgniteStripedThreadPoolExecutor(
ctx.config().getQueryThreadPoolSize(),
ctx.igniteInstanceName(),
"calciteQry",
this,
false,
0
- ));
+ );
+
+ stripedThreadPoolExecutor(executor);
+
+
executor.registerMetrics(ctx.metric().registry(metricName(THREAD_POOLS,
THREAD_POOL_NAME)));
Review Comment:
Should we also add a view like for DataStreamer pool?
` ctx.systemView().registerInnerCollectionView("CalciteQueryPool",
"Pool for query executions", ...`
If I'm correct, these pool views are added at IgniteKernal.start() /
GridComponent.onKernalStart()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
