valepakh commented on code in PR #2607:
URL: https://github.com/apache/ignite-3/pull/2607#discussion_r1331162888


##########
modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/node/NodeState.java:
##########
@@ -34,11 +34,19 @@ public class NodeState {
     @Schema(description = "Node status.", requiredMode = RequiredMode.REQUIRED)
     private final State state;
 
+    @Schema(description = "Node jdbc port.", requiredMode = 
RequiredMode.REQUIRED)

Review Comment:
   ```suggestion
       @Schema(description = "Node JDBC port.", requiredMode = 
RequiredMode.REQUIRED)
   ```



##########
modules/rest/src/main/java/org/apache/ignite/internal/rest/node/JdbcPortProvider.java:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.rest.node;
+
+/**
+ * Provides jdbc port.

Review Comment:
   ```suggestion
    * Provides JDBC port.
   ```



##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/JdbcPortProviderImpl.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.configuration;
+
+import 
org.apache.ignite.client.handler.configuration.ClientConnectorConfiguration;
+import org.apache.ignite.internal.rest.node.JdbcPortProvider;
+
+/**
+ * Provider of client port form node configuration.

Review Comment:
   ```suggestion
    * Provider of client port from node configuration.
   ```



##########
modules/rest-api/openapi/openapi.yaml:
##########
@@ -891,6 +892,10 @@ components:
           - $ref: '#/components/schemas/State'
           - type: object
             description: Node status.
+        jdbcPort:
+          type: integer
+          description: Node jdbc port.

Review Comment:
   ```suggestion
             description: Node JDBC port.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to