lowka commented on code in PR #2601:
URL: https://github.com/apache/ignite-3/pull/2601#discussion_r1331705105
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/CatalogSqlSchemaManager.java:
##########
@@ -140,12 +143,22 @@ private static SchemaPlus createSqlSchema(int version,
CatalogSchemaDescriptor s
IgniteTable schemaTable = new IgniteTableImpl(tableName, tableId,
version, descriptor, statistic, tableIndexMap);
- schemaTables.add(schemaTable);
+ schemaDataSources.add(schemaTable);
+ }
+
+ for (CatalogSystemViewDescriptor systemViewDescriptor :
schemaDescriptor.systemViews()) {
+ int viewId = systemViewDescriptor.id();
+ String viewName = systemViewDescriptor.name();
+ TableDescriptor descriptor =
createTableDescriptorForSystemView(systemViewDescriptor);
+
+ IgniteSystemView schemaTable = new IgniteSystemViewImpl(viewName,
viewId, version, descriptor, Statistics.UNKNOWN);
Review Comment:
Unfortunately, there is no statistics for system views, because the API asks
user to provide it a function that returns data (see SystemView's dataProvider
property).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
