zstan commented on code in PR #2615:
URL: https://github.com/apache/ignite-3/pull/2615#discussion_r1334246635
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java:
##########
@@ -151,22 +150,12 @@ public static RelDataType
combinedRowType(IgniteTypeFactory typeFactory, RelData
return builder.build();
}
- /**
- * CreateRowType.
- * TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
- */
- public static RelDataType createRowType(IgniteTypeFactory typeFactory,
Class<?>... fields) {
- List<RelDataType> types = Arrays.stream(fields)
- .map(typeFactory::createJavaType)
- .collect(Collectors.toList());
-
- return createRowType(typeFactory, types, "$F");
+ /** Assembly output type from input types. */
+ public static RelDataType createRowType(IgniteTypeFactory typeFactory,
List<RelDataType> fields) {
+ return createRowType(typeFactory, fields.toArray(new RelDataType[0]));
Review Comment:
you are right, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
