AMashenkov commented on code in PR #2602:
URL: https://github.com/apache/ignite-3/pull/2602#discussion_r1337367820
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalNode.java:
##########
@@ -52,19 +56,32 @@ public LogicalNode(
) {
super(id, name, address);
- this.nodeAttributes = Collections.emptyMap();
+ this.attributes = Collections.emptyMap();
+ this.systemAttributes = Collections.emptyMap();
}
/**
* Constructor.
*
- * @param clusterNode Represents a node in a cluster.
- * @param nodeAttributes Node attributes.
+ * @param clusterNode Represents a node in a cluster.
+ * @param attributes Node attributes defined in configuration.
+ */
+ public LogicalNode(ClusterNode clusterNode, Map<String, String>
attributes) {
+ this(clusterNode, attributes, Collections.emptyMap());
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param clusterNode Represents a node in a cluster.
+ * @param attributes Node attributes defined in configuration.
+ * @param systemAttributes Internal node attributes provided by system
components at startup.
*/
- public LogicalNode(ClusterNode clusterNode, Map<String, String>
nodeAttributes) {
+ public LogicalNode(ClusterNode clusterNode, @Nullable Map<String, String>
attributes, @Nullable Map<String, String> systemAttributes) {
Review Comment:
Seems, we can avoid null arguments at all and drop @Nullable annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
