ibessonov commented on code in PR #2571:
URL: https://github.com/apache/ignite-3/pull/2571#discussion_r1338194770
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/configuration/PageMemoryStorageDistributedConfigurationModule.java:
##########
@@ -44,7 +42,7 @@ public ConfigurationType type() {
/** {@inheritDoc} */
@Override
public Collection<RootKey<?, ?>> rootKeys() {
- return List.of(VolatilePageMemoryStorageEngineConfiguration.KEY,
PersistentPageMemoryStorageEngineConfiguration.KEY);
+ return List.of();
Review Comment:
You forgot about other methods. Why did you left the class if there's no
distributed storage configuration anymore? You could have renamed it at that's
it.
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/core/repl/executor/ItIgnitePicocliCommandsTest.java:
##########
@@ -265,7 +265,9 @@ void nodeConfigUpdateSuggested(ParsedLine givenParsedLine) {
// wait for lazy init of node config completer
await("For given parsed words: " + givenParsedLine.words()).until(
() -> complete(givenParsedLine),
- containsInAnyOrder("rest", "clientConnector", "network",
"cluster", "deployment", "nodeAttributes")
+ containsInAnyOrder(
+ "rest", "clientConnector", "network", "cluster",
"deployment", "nodeAttributes", "aimem", "aipersist", "rocksDb"
Review Comment:
I believe we should use lower case for "rocksdb", but let's discuss it in
the future
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##########
@@ -778,12 +778,21 @@ private class Node {
vaultManager = createVault(name, dir);
nodeCfgGenerator = new ConfigurationTreeGenerator(
- NetworkConfiguration.KEY, RestConfiguration.KEY,
ClientConnectorConfiguration.KEY
- );
+ List.of(
+ NetworkConfiguration.KEY,
+ RestConfiguration.KEY,
+ ClientConnectorConfiguration.KEY,
+ PersistentPageMemoryStorageEngineConfiguration.KEY,
+ VolatilePageMemoryStorageEngineConfiguration.KEY),
+ List.of(),
+ List.of(UnsafeMemoryAllocatorConfigurationSchema.class)
+ );
Review Comment:
```suggestion
);
```
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/configuration/RocksDbStorageDistributedConfigurationModule.java:
##########
@@ -42,7 +41,7 @@ public ConfigurationType type() {
/** {@inheritDoc} */
@Override
public Collection<RootKey<?, ?>> rootKeys() {
- return List.of(RocksDbStorageEngineConfiguration.KEY);
+ return List.of();
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
