zstan commented on code in PR #2611:
URL: https://github.com/apache/ignite-3/pull/2611#discussion_r1350334913
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/AsyncSqlCursorImplTest.java:
##########
@@ -82,7 +83,7 @@ public void testExceptionRollbacksImplicitTx(boolean
implicit, QueryTransactionW
CompletionException t = assertThrows(CompletionException.class, () ->
cursor.requestNextAsync(1).join());
CompletableFuture<Void> f = ((NoOpTransaction)
txWrapper.unwrap()).rollbackFuture();
- assertEquals(implicit, f.isDone(), "Implicit transaction should have
been rolled back: " + f);
+ assertTrue(f.isDone(), "Implicit transaction should have been rolled
back: " + f);
Review Comment:
not only implicit, as i can see ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
