xtern commented on code in PR #2683:
URL: https://github.com/apache/ignite-3/pull/2683#discussion_r1358055617
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryType.java:
##########
@@ -33,7 +34,15 @@ public enum SqlQueryType {
DDL,
/** Explain. */
- EXPLAIN;
+ EXPLAIN,
+
+ /** Transaction control statements such as {@code START TRANSACTION},
{@code COMMIT}, etc. */
+ TX_CONTROL,
+
+ ;
+
+ /** A set of statement types that can run only in single statement mode.
**/
Review Comment:
For me this doesn't match with current PR description "Add restrictions for
execution tx related statements with single statement mode" :thinking:
I thought that the main goal is to throw exception if
SqlQueryProcessor#querySingle processing tx-related statements, but may be I'm
missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
