rpuch commented on code in PR #2676: URL: https://github.com/apache/ignite-3/pull/2676#discussion_r1360241874
########## modules/index/src/test/java/org/apache/ignite/internal/index/IndexAvailabilityControllerTest.java: ########## @@ -0,0 +1,405 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.index; + +import static java.util.concurrent.CompletableFuture.completedFuture; +import static org.apache.ignite.internal.catalog.CatalogService.DEFAULT_SCHEMA_NAME; +import static org.apache.ignite.internal.catalog.CatalogService.DEFAULT_ZONE_NAME; +import static org.apache.ignite.internal.testframework.IgniteTestUtils.waitForCondition; +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willBe; +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willCompleteSuccessfully; +import static org.apache.ignite.internal.util.ArrayUtils.BYTE_EMPTY_ARRAY; +import static org.apache.ignite.sql.ColumnType.INT32; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.greaterThan; +import static org.hamcrest.Matchers.nullValue; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +import java.util.List; +import java.util.concurrent.CompletableFuture; +import java.util.stream.Stream; +import org.apache.ignite.internal.catalog.CatalogManager; +import org.apache.ignite.internal.catalog.CatalogTestUtils; +import org.apache.ignite.internal.catalog.commands.AlterZoneParams; +import org.apache.ignite.internal.catalog.commands.ColumnParams; +import org.apache.ignite.internal.catalog.descriptors.CatalogIndexDescriptor; +import org.apache.ignite.internal.catalog.descriptors.CatalogZoneDescriptor; +import org.apache.ignite.internal.hlc.HybridClock; +import org.apache.ignite.internal.hlc.HybridClockImpl; +import org.apache.ignite.internal.lang.ByteArray; +import org.apache.ignite.internal.manager.IgniteComponent; +import org.apache.ignite.internal.metastorage.Entry; +import org.apache.ignite.internal.metastorage.impl.MetaStorageManagerImpl; +import org.apache.ignite.internal.metastorage.impl.StandaloneMetaStorageManager; +import org.apache.ignite.internal.replicator.ReplicaService; +import org.apache.ignite.internal.storage.MvPartitionStorage; +import org.apache.ignite.internal.storage.RowId; +import org.apache.ignite.internal.storage.index.IndexStorage; +import org.apache.ignite.internal.table.TableTestUtils; +import org.apache.ignite.internal.table.distributed.index.IndexBuilder; +import org.apache.ignite.internal.testframework.BaseIgniteAbstractTest; +import org.apache.ignite.internal.util.IgniteUtils; +import org.apache.ignite.internal.vault.VaultManager; +import org.apache.ignite.internal.vault.inmemory.InMemoryVaultService; +import org.apache.ignite.network.ClusterNode; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +/** For {@link IndexAvailabilityController} testing. */ +public class IndexAvailabilityControllerTest extends BaseIgniteAbstractTest { + private static final String NODE_NAME = "test-node"; + + private static final String TABLE_NAME = "test-table"; + + private static final String COLUMN_NAME = "test-column"; + + private static final String INDEX_NAME = "test-index"; + + private final HybridClock clock = new HybridClockImpl(); + + private int partitions; + + private VaultManager vaultManager; + + private MetaStorageManagerImpl metaStorageManager; + + private CatalogManager catalogManager; + + private IndexBuilder indexBuilder; + + private IndexAvailabilityController indexAvailabilityController; + + @BeforeEach + void setUp() { + vaultManager = new VaultManager(new InMemoryVaultService()); + + metaStorageManager = StandaloneMetaStorageManager.create(vaultManager); + + catalogManager = CatalogTestUtils.createTestCatalogManager(NODE_NAME, clock, metaStorageManager); + + indexBuilder = new IndexBuilder(NODE_NAME, 1, mock(ReplicaService.class, invocation -> completedFuture(null))); + + indexAvailabilityController = new IndexAvailabilityController(catalogManager, metaStorageManager, indexBuilder); + + Stream.of(vaultManager, metaStorageManager, catalogManager).forEach(IgniteComponent::start); + + assertThat(metaStorageManager.deployWatches(), willCompleteSuccessfully()); + + CatalogZoneDescriptor zoneDescriptor = catalogManager.zone(DEFAULT_ZONE_NAME, clock.nowLong()); + + assertNotNull(zoneDescriptor); + + partitions = zoneDescriptor.partitions(); + + assertThat(partitions, greaterThan(4)); + + TableTestUtils.createTable( + catalogManager, + DEFAULT_SCHEMA_NAME, + DEFAULT_ZONE_NAME, + TABLE_NAME, + List.of(ColumnParams.builder().name(COLUMN_NAME).type(INT32).build()), + List.of(COLUMN_NAME) + ); + } + + @AfterEach + void tearDown() throws Exception { + IgniteUtils.closeAll( + indexAvailabilityController == null ? null : indexAvailabilityController::close, + indexBuilder == null ? null : indexBuilder::close, + catalogManager == null ? null : catalogManager::stop, + metaStorageManager == null ? null : metaStorageManager::stop, + vaultManager == null ? null : vaultManager::stop + ); + } + + @Test + void testMetastoreKeysAfterIndexCreate() throws Exception { + createIndex(INDEX_NAME); + + int indexId = indexId(INDEX_NAME); + + awaitActualMetastoreRevision(); + + assertStartBuildIndexKeyExists(indexId); + + for (int partitionId = 0; partitionId < partitions; partitionId++) { + assertPartitionBuildIndexKeyExists(indexId, partitionId); + } + } + + @Test + void testMetastoreKeysAfterIndexCreateForOnlyOnePartition() throws Exception { + changePartitionCountInCatalog(1); + + testMetastoreKeysAfterIndexCreate(); + } + + @Test + void testMetastoreKeysAfterFinishBuildIndexForOnePartition() throws Exception { + createIndex(INDEX_NAME); + + int indexId = indexId(INDEX_NAME); + + finishBuildingIndexForPartition(indexId, 0); + + awaitActualMetastoreRevision(); + + assertStartBuildIndexKeyExists(indexId); + + assertPartitionBuildIndexKeyAbsent(indexId, 0); + + for (int partitionId = 1; partitionId < partitions; partitionId++) { + assertPartitionBuildIndexKeyExists(indexId, partitionId); + } + + assertTrue(indexDescriptor(INDEX_NAME).writeOnly()); + } + + @Test + void testMetastoreKeysAfterFinishBuildIndexForAllPartition() throws Exception { + createIndex(INDEX_NAME); + + int indexId = indexId(INDEX_NAME); + + for (int partitionId = 0; partitionId < partitions; partitionId++) { + assertThat( + metaStorageManager.remove(ByteArray.fromString(partitionBuildIndexKey(indexId, partitionId))), + willCompleteSuccessfully() + ); + } + + awaitActualMetastoreRevision(); + + assertStartBuildIndexKeyAbsent(indexId); + + for (int partitionId = 0; partitionId < partitions; partitionId++) { + assertPartitionBuildIndexKeyAbsent(indexId, partitionId); + } + + assertFalse(indexDescriptor(INDEX_NAME).writeOnly()); + } + + @Test + void testMetastoreKeysAfterDropIndex() throws Exception { + createIndex(INDEX_NAME); + + int indexId = indexId(INDEX_NAME); + + dropIndex(INDEX_NAME); + + awaitActualMetastoreRevision(); + + assertStartBuildIndexKeyAbsent(indexId); + + for (int partitionId = 0; partitionId < partitions; partitionId++) { + assertPartitionBuildIndexKeyAbsent(indexId, partitionId); + } + } + + @Test + void testMetastoreKeysAfterDropIndexForOnlyOnePartition() throws Exception { + changePartitionCountInCatalog(1); + + testMetastoreKeysAfterDropIndex(); + } + + @Test + void testMetastoreKeysAfterFinishBuildingOnePartitionAndDropIndex() throws Exception { + createIndex(INDEX_NAME); + + int indexId = indexId(INDEX_NAME); + + finishBuildingIndexForPartition(indexId, 0); + + dropIndex(INDEX_NAME); + + awaitActualMetastoreRevision(); + + assertStartBuildIndexKeyAbsent(indexId); + + for (int partitionId = 0; partitionId < partitions; partitionId++) { + assertPartitionBuildIndexKeyAbsent(indexId, partitionId); + } + } + + @Test + void testMetastoreKeysAfterDropIndexWithLastRemainingPartition() throws Exception { + createIndex(INDEX_NAME); + + int indexId = indexId(INDEX_NAME); + + for (int partitionId = 1; partitionId < partitions; partitionId++) { + finishBuildingIndexForPartition(indexId, partitionId); + } + + dropIndex(INDEX_NAME); + + awaitActualMetastoreRevision(); + + assertStartBuildIndexKeyAbsent(indexId); + + for (int partitionId = 0; partitionId < partitions; partitionId++) { + assertPartitionBuildIndexKeyAbsent(indexId, partitionId); + } + } + + @Test + void testMetastoreKeysAfterDropIndexWithTwoRemainingPartition() throws Exception { + createIndex(INDEX_NAME); + + int indexId = indexId(INDEX_NAME); + + for (int partitionId = 2; partitionId < partitions; partitionId++) { + finishBuildingIndexForPartition(indexId, partitionId); + } + + dropIndex(INDEX_NAME); + + awaitActualMetastoreRevision(); + + assertStartBuildIndexKeyAbsent(indexId); + + for (int partitionId = 0; partitionId < partitions; partitionId++) { + assertPartitionBuildIndexKeyAbsent(indexId, partitionId); + } + } + + private void awaitActualMetastoreRevision() throws Exception { Review Comment: `awaitTillGlobalMetastoreRevisionIsApplied()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
