xtern commented on PR #2674: URL: https://github.com/apache/ignite-3/pull/2674#issuecomment-1766399895
> The goal of the JIRA is to eliminate dependency on the user's input while processing the script. `AsyncSqlCursorImpl#requestNextAsync` is a user input for sure. Besides, the description of the ticket points out to a particular place that triggers prefetch (`AsyncRootNode#prefetch`). End of the prefetch is the moment when `waiting` reaches 0 for the first time. So, we need to trigger listeners when `waiting` reaches 0 after `AsyncRootNode#prefetch` was invoked. > > BTW, I think, the name `listener` is more suitable for recurrent events, while for single shot notification 'callback' fits better @korlov42 Yes :woman_facepalming:, thanks for the detailed explanation. I've reworked the patch, please have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
